acezen commented on code in PR #629:
URL: https://github.com/apache/incubator-graphar/pull/629#discussion_r1763466774
##########
.devcontainer/devcontainer.json:
##########
@@ -22,7 +22,7 @@
{
"name": "GraphAr",
// Or use a Dockerfile or Docker Compose file. More info:
https://containers.dev/guide/dockerfile
- "image": "ghcr.io/apache/graphar-dev:latest",
Review Comment:
the image name is
[graphar-dev](https://github.com/apache/incubator-graphar/pkgs/container/graphar-dev)
##########
licenserc.toml:
##########
@@ -45,19 +45,19 @@ excludes = [
"cpp/apidoc",
Review Comment:
Ditto
##########
maven-projects/spark/README.md:
##########
@@ -164,7 +164,7 @@ We can write a json configuration file like
`import/neo4j.json` to do the import
Running this example requires `Docker` to be installed, if not, follow [this
link](https://docs.docker.com/engine/install/). Run `docker version` to check
it.
Spark provides a simple example to convert NebulaGraph data to GraphAr data.
-The example is located in the directory
``spark/graphar/src/main/scala/org/apache/graphar/example/``.
Review Comment:
Ditto.
##########
maven-projects/spark/README.md:
##########
@@ -237,7 +237,7 @@ The example will import the basketballplayer graph from
GraphAr to NebulaGraph a
## Running the local LDBC sample data to GraphAr example
we provide a simple example to convert LDBC sample data to GraphAr data.
-this example is located in the directory
``spark/graphar/src/main/scala/org/apache/graphar/example/``.
Review Comment:
Dotto
##########
LICENSE:
##########
@@ -214,26 +214,26 @@ The text of each license is the standard Apache 2.0
license.
* Apache Spark 3.1.1 and 3.3.4 (https://github.com/apache/spark)
Files:
-
maven-projects/spark/datasourcs-32/src/main/scala/org/apache/graphar/datasources/GarCommitProtocol.scala
Review Comment:
The files include in the LICENSE are correct, no need to update them.
##########
docs/libraries/spark/examples.md:
##########
@@ -203,8 +203,8 @@ See [GraphAr2Neo4j.scala][graphar2neo4j] for the complete
example.
:::
-[test-graph-transformer]:
https://github.com/apache/incubator-graphar/blob/main/maven-projects/spark/graphar/src/test/scala/org/apache/graphar/TestGraphTransformer.scala
Review Comment:
Ditto, no need to update the links of examples.
##########
maven-projects/spark/README.md:
##########
@@ -73,7 +73,7 @@ The API document is generated in the directory
``spark/graphar/target/site/scala
## Running Neo4j to GraphAr example
Spark provides a simple example to convert Neo4j data to GraphAr data.
-The example is located in the directory
``spark/graphar/src/main/scala/org/apache/graphar/example/``.
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
