This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 8ccdd55e581e0dfde54b898778392744cd2431f8 Author: Walter Duque de Estrada <[email protected]> AuthorDate: Mon Feb 23 17:59:26 2026 -0600 remove unused method --- grails-data-hibernate7/GORM-QUERY-SAFETY-AUDIT.md | 11 ++--------- .../orm/hibernate/HibernateGormInstanceApi.groovy | 18 ------------------ 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/grails-data-hibernate7/GORM-QUERY-SAFETY-AUDIT.md b/grails-data-hibernate7/GORM-QUERY-SAFETY-AUDIT.md index 9c2ebfda76..a0ec9672b1 100644 --- a/grails-data-hibernate7/GORM-QUERY-SAFETY-AUDIT.md +++ b/grails-data-hibernate7/GORM-QUERY-SAFETY-AUDIT.md @@ -138,19 +138,12 @@ The `executeUpdate(CharSequence)` single-arg overload was the highest-severity i --- -### M-3 · `HibernateGormInstanceApi.nextId()` — GString with Class Name in HQL ✅ FIXED +### M-3 · `HibernateGormInstanceApi.nextId()` — Dead Code Removed ✅ FIXED | Field | Value | |-------|-------| | **File** | `core/src/main/groovy/org/grails/orm/hibernate/HibernateGormInstanceApi.groovy` | -| **Line** | 178 | -| **Status** | ✅ Fixed — not an active injection risk; renamed to plain concatenation to avoid confusing the GString parameterizer | - -`persistentEntity.name` is framework metadata, not user input. The GString caused `buildNamedParameterQueryFromGString` to bind the class name as `:p0`, producing malformed HQL. Fixed to plain concatenation: - -```groovy -String hql = "select max(e.id) from " + persistentEntity.name + " e" -``` +| **Status** | ✅ Removed — method had no callers; was left over from the Hibernate 5 `GrailsIncrementGenerator` strategy | --- diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormInstanceApi.groovy b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormInstanceApi.groovy index 6daf2fc332..acef5522cf 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormInstanceApi.groovy +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormInstanceApi.groovy @@ -174,24 +174,6 @@ class HibernateGormInstanceApi<D> extends GormInstanceApi<D> { } - private Long nextId() { - String hql = "select max(e.id) from ${persistentEntity.name} e" - - def result = (Long) HibernateHqlQuery.createHqlQuery( - (HibernateDatastore) datastore, - sessionFactory, - persistentEntity, - hql, - false, - false, - null, - null - , null - , (GrailsHibernateTemplate) hibernateTemplate).singleResult() ?: 0 - Random random = new Random() - return result + random.nextInt(100) + 1 - } - @CompileDynamic private void runDeferredBinding() { DEFERRED_BINDING?.runActions()
