JkSelf opened a new pull request, #11643:
URL: https://github.com/apache/incubator-gluten/pull/11643
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
When offloading Hash Join to Velox, Gluten currently cannot fully leverage
the performance benefits of the Hash Join Key Rewriting feature. In fact,
enabling this feature can lead to performance degradation.
During our optimization of BHJ—aimed at building the hash table only once
per executor—we discovered that Dynamic Filter Push-down DFP is enabled when
Key Rewriting is enabled. This occurs because the rewriting process introduces
CAST(int AS long) expressions to both the Build and Probe sides within the
Project operator. Since Velox only supports filter push-down on columns without
complex expressions, these added casts block the optimization, resulting in a
performance degradation.
To address this, we have disabled the Key Rewriting feature specifically
within the HashJoin#canRewriteAsLongType method.
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
Existing unit tests
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
No
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
