zhztheplayer commented on code in PR #10821:
URL:
https://github.com/apache/incubator-gluten/pull/10821#discussion_r2387809100
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/TakeOrderedAndProjectExecTransformer.scala:
##########
@@ -143,6 +143,7 @@ case class TakeOrderedAndProjectExecTransformer(
} else {
val limitStagePlan =
WholeStageTransformer(limitBeforeShuffle)(transformStageCounter.incrementAndGet())
+ limitStagePlan.copyTagsFrom(child)
Review Comment:
Doing this may bring some subtle shortcomings because `limitStagePlan` is
not logically equal to `child` (they don't output the same data from user's
view). Thus, the new code may work for cuDF but may technically break other
tags.
Can we invoke the code in `CudfNodeValidationRule` here to specifically add
the cuDF tags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
