PHILO-HE commented on code in PR #10776:
URL:
https://github.com/apache/incubator-gluten/pull/10776#discussion_r2388412295
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -80,6 +80,8 @@ class VeloxConfig(conf: SQLConf) extends GlutenConfig(conf) {
getConf(ENABLE_ENHANCED_FEATURES)
def veloxPreferredBatchBytes: Long =
getConf(COLUMNAR_VELOX_PREFERRED_BATCH_BYTES)
+
+ def maxCompiledRegexes: Int = getConf(VELOX_MAX_COMPILED_REGEXES)
Review Comment:
Do we need this? If this config will not be accessed by Scala code, maybe we
can just remove it.
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -646,4 +648,10 @@ object VeloxConfig {
.internal()
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("10MB")
+
+ val VELOX_MAX_COMPILED_REGEXES =
+ buildConf("spark.gluten.sql.columnar.backend.velox.maxCompiledRegexes")
+ .doc("Controls maximum number of compiled regular expression patterns
per batch.")
Review Comment:
Velox's comments for the corresponding looks clearer. Maybe, we can just
copy them here.
https://github.com/facebookincubator/velox/blob/8875b4d08b26be2743bb5e79efe0548bebd08042/velox/core/QueryConfig.h#L91-L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
