zhztheplayer commented on code in PR #10573:
URL:
https://github.com/apache/incubator-gluten/pull/10573#discussion_r2336058791
##########
backends-velox/src/main/scala/org/apache/spark/api/python/ColumnarArrowEvalPythonExec.scala:
##########
@@ -333,8 +333,9 @@ case class ColumnarArrowEvalPythonExec(
val inputBatchIter = contextAwareIterator.map {
inputCb =>
start_time = System.nanoTime()
- ColumnarBatches.checkLoaded(inputCb)
- ColumnarBatches.retain(inputCb)
+ val batchType = ColumnarBatches.identifyBatchType(inputCb)
+ ColumnarBatches.checkLoaded(batchType)
+ ColumnarBatches.retain(inputCb, batchType)
Review Comment:
I still wonder exposing the batch types to developers will increase the
overall complexity. Would you be okay if we extend the ColumnarBatch class
after 3.2 is dropped instead? I assume that would not be a long time to wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
