PHILO-HE commented on code in PR #10659:
URL:
https://github.com/apache/incubator-gluten/pull/10659#discussion_r2338315456
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -538,6 +538,7 @@ object VeloxConfig {
val VELOX_BROADCAST_BUILD_RELATION_USE_OFFHEAP =
buildConf("spark.gluten.velox.offHeapBroadcastBuildRelation.enabled")
.internal()
+ .experimental()
Review Comment:
If we always assume experimental configs fall under the internal category, I
think it would be better to add an assertion check in the experimental API to
ensure they have been marked as internal. Otherwise, I'm concerned that
developers might forget to mark experimental configs as internal, potentially
making experimental configs public unintentionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
