FelixYBW commented on code in PR #10619:
URL:
https://github.com/apache/incubator-gluten/pull/10619#discussion_r2324357636
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -61,9 +62,26 @@ class VeloxMetricsApi extends MetricsApi with Logging {
)
}
+ val wallNanosMetric = if (forShuffle) {
+ // For input from shuffle, the time of shuffle read is inclusive to the
metrics.
+ SQLMetrics.createNanoTimingMetric(
+ sparkContext,
+ "time of input iterator (shuffle read time inclusive)")
+ } else if (forBroadcast) {
+ // For input from broadcast, the time of broadcasting is exclusive.
+ SQLMetrics.createNanoTimingMetric(
+ sparkContext,
+ "time of input iterator (broadcast time exclusive)")
+ } else {
+ // For other occasions, e.g. fallback, union, the time of the previous
pipeline is inclusive.
+ SQLMetrics.createNanoTimingMetric(
+ sparkContext,
+ "time of input iterator (previous pipeline time inclusive)")
Review Comment:
time of operator input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
