marin-ma commented on code in PR #10616:
URL:
https://github.com/apache/incubator-gluten/pull/10616#discussion_r2318860269
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -553,30 +553,19 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
partitioning: Partitioning,
output: Seq[Attribute]): ShuffleWriterType = {
val conf = GlutenConfig.get
- // todo: remove isUseCelebornShuffleManager here
- if (conf.isUseCelebornShuffleManager) {
- if (conf.celebornShuffleWriterType ==
ReservedKeys.GLUTEN_SORT_SHUFFLE_WRITER) {
- if (conf.useCelebornRssSort) {
- RssSortShuffleWriterType
- } else if (partitioning != SinglePartition) {
+ SparkEnv.get.shuffleManager match {
+ case shuffleManager: NeedCustomShuffleWriterType =>
Review Comment:
There's a trait `SupportsColumnarShuffle`. We can add and implement method
`getColumnarShuffleWriterType` for the supported shuffle managers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
