beliefer commented on code in PR #10350:
URL:
https://github.com/apache/incubator-gluten/pull/10350#discussion_r2271928586
##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/NativePlanEvaluator.java:
##########
@@ -87,7 +86,7 @@ public ColumnarBatchOutIterator createKernelWithBatchIterator(
new Spiller() {
@Override
public long spill(MemoryTarget self, Spiller.Phase phase, long
size) {
- if (!Spillers.PHASE_SET_SPILL_ONLY.contains(phase)) {
+ if (!Spiller.Phase.SPILL.equals(phase)) {
return 0L;
Review Comment:
Java style recommends `if` if there is only one branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
