JkSelf commented on code in PR #10310:
URL:
https://github.com/apache/incubator-gluten/pull/10310#discussion_r2246719837
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/datasources/GlutenWriterColumnarRules.scala:
##########
@@ -39,10 +39,6 @@ object GlutenWriterColumnarRules {
"org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat" ->
"parquet"
)
private def getNativeFormat(cmd: DataWritingCommand): Option[String] = {
- if (!BackendsApiManager.getSettings.enableNativeWriteFiles()) {
Review Comment:
From a code readability perspective, it makes more sense to keep this check
within the getNativeFormat method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
