This is an automated email from the ASF dual-hosted git repository.

mingliang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 641d6e19b6 [MINOR][CORE] Simplify fillWithTransitions for 
InsertTransitions (#10297)
641d6e19b6 is described below

commit 641d6e19b6541fc4a4313d66948f812dea21440e
Author: Jiaan Geng <[email protected]>
AuthorDate: Thu Jul 31 13:38:46 2025 +0800

    [MINOR][CORE] Simplify fillWithTransitions for InsertTransitions (#10297)
---
 .../apache/gluten/extension/columnar/transition/Transitions.scala    | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git 
a/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transitions.scala
 
b/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transitions.scala
index 3e55b0e11a..2ea30b6af0 100644
--- 
a/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transitions.scala
+++ 
b/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transitions.scala
@@ -35,13 +35,10 @@ case class InsertTransitions(convReq: ConventionReq) 
extends Rule[SparkPlan] {
   }
 
   private def fillWithTransitions(plan: SparkPlan): SparkPlan = 
plan.transformUp {
-    case p => applyForNode(p)
+    case node if node.children.nonEmpty => applyForNode(node)
   }
 
   private def applyForNode(node: SparkPlan): SparkPlan = {
-    if (node.children.isEmpty) {
-      return node
-    }
     val convReqs = convFunc.conventionReqOf(node)
     val newChildren = node.children.zip(convReqs).map {
       case (child, convReq) =>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to