shuai-xu commented on code in PR #10229:
URL:
https://github.com/apache/incubator-gluten/pull/10229#discussion_r2244280606
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -57,6 +57,23 @@ void testSubtract() {
runAndCheck(query2, Arrays.asList("+I[0]", "+I[1]", "+I[2]"));
}
+ @Test
+ void testDiv() {
+ List<Row> rows = Arrays.asList(Row.of(1, 1L, 1.0), Row.of(2, 2L, 1.0),
Row.of(3, 3L, 2.0));
Review Comment:
Maybe need more cases to verify the results. Such as divide 0, divide
decimal and check the precise, double divide double and check the precise same
with flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
