Philipp Hörist pushed to branch master at gajim / gajim
Commits:
43b5bad0 by Philipp Hörist at 2026-01-27T23:32:10+01:00
imprv: Preferences: Remove password entry
There is no need for the password entry in the Preference dialog. If Gajim
needs the password it will ask for it on connect.
This also prevents unnecessary password retrivals which slows the startup of
the dialog.
- - - - -
2 changed files:
- gajim/gtk/preference/account.py
- gajim/gtk/settings.py
Changes:
=====================================
gajim/gtk/preference/account.py
=====================================
@@ -697,13 +697,6 @@ def __init__(self, account: str) -> None:
)
settings = [
- Setting(
- SettingKind.ENTRY,
- _("Password"),
- SettingType.ACCOUNT_CONFIG,
- "password",
- bind="account::savepass",
- ),
Setting(
SettingKind.SWITCH,
_("Save Password"),
=====================================
gajim/gtk/settings.py
=====================================
@@ -22,7 +22,6 @@
from nbxmpp.protocol import JID
from gajim.common import app
-from gajim.common import passwords
from gajim.common.ged import EventHelper
from gajim.common.i18n import _
from gajim.common.i18n import p_
@@ -410,8 +409,6 @@ def __get_value(
return app.settings.get(value)
if type_ == SettingType.ACCOUNT_CONFIG:
- if value == "password":
- return passwords.get_password(account)
return app.settings.get_account_setting(account, value)
if type_ == SettingType.ACTION:
@@ -427,11 +424,7 @@ def set_value(self, state: AllSettingsT) -> None:
app.settings.set(self.value, state)
elif self.type_ == SettingType.ACCOUNT_CONFIG:
- if self.value == "password":
- assert isinstance(state, str)
- passwords.save_password(self.account, state)
- else:
- app.settings.set_account_setting(self.account, self.value,
state)
+ app.settings.set_account_setting(self.account, self.value, state)
elif self.type_ == SettingType.CONTACT:
app.settings.set_contact_setting(self.account, self.jid,
self.value, state)
@@ -550,9 +543,6 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
self.entry.set_valign(Gtk.Align.CENTER)
self.entry.set_alignment(1)
- if self.value == "password":
- self.entry.set_visibility(False)
-
self.setting_box.prepend(self.entry)
assert isinstance(self.value, str)
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/43b5bad06dd9a999949f87910b427b41828c71f4
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/43b5bad06dd9a999949f87910b427b41828c71f4
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
