Philipp Hörist pushed to branch master at gajim / gajim


Commits:
f7e85a59 by mesonium at 2025-11-10T20:31:44+01:00
fix: Voice Messages: Show Play Icon, when showing Audio Player

- - - - -
4517d2e0 by mesonium at 2025-11-10T20:31:50+01:00
fix: Voice Messages: Update waveform on seek during pause

This was broken, when the audio player didn't play the track the user 
interacted with.

- - - - -


1 changed file:

- gajim/gtk/preview/audio.py


Changes:

=====================================
gajim/gtk/preview/audio.py
=====================================
@@ -172,13 +172,17 @@ def __init__(
                 self._display_audio_preview()
 
     @property
-    def id(self):
+    def id(self) -> int:
         return self._id
 
-    def do_unroot(self):
+    def do_unroot(self) -> None:
         self._cleanup()
 
     def sample_voice_message(self, audio_path: Path) -> None:
+        assert app.audio_player is not None
+        if app.audio_player.preview_id == self._id:
+            app.audio_player.stop(self._id)
+        self._play_icon.set_from_icon_name("lucide-play-symbolic")
         self._orig_path = audio_path
         self._preview_state.position = 0
         self._seek_bar.set_value(0)
@@ -373,7 +377,7 @@ def _on_seek_bar_cursor_move(
             return
 
         if self._is_ltr:
-            pos_x = x + SEEK_BAR_PADDING + 1
+            pos_x = x + SEEK_BAR_PADDING
         else:
             width = self._seek_bar.get_width()
             pos_x = width - (x + SEEK_BAR_PADDING)
@@ -388,7 +392,10 @@ def _on_seek_bar_cursor_move(
             self._user_holds_position_slider
             and self._preview_state.pipeline_state != AudioPlayerState.PLAYING
         ):
-            app.audio_player.set_playback_position(self._id, seek_ts)
+            if app.audio_player.preview_id != self.id:
+                self._preview_state.position = seek_ts
+            else:
+                app.audio_player.set_playback_position(self._id, seek_ts)
             self._update_ui_from_state()
         else:
             self._seek_ts = seek_ts



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/compare/a6db66dfe929492c337434dcf0e2e4cda59ff330...4517d2e028995514da1b441854ef73b3e7b7b301

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/compare/a6db66dfe929492c337434dcf0e2e4cda59ff330...4517d2e028995514da1b441854ef73b3e7b7b301
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to