Daniel Brötzmann pushed to branch master at gajim / gajim
Commits:
282321ed by wurstsalat at 2025-10-24T22:12:09+02:00
fix: File selector/avatar selector: Guard for missing value on drop
Fixes #12505
- - - - -
2 changed files:
- gajim/gtk/avatar_selector.py
- gajim/gtk/file_transfer_selector.py
Changes:
=====================================
gajim/gtk/avatar_selector.py
=====================================
@@ -127,8 +127,12 @@ def _on_drop_accept(self, _target: Gtk.DropTarget, drop:
Gdk.Drop) -> bool:
return bool(formats.contain_gtype(Gdk.FileList))
def _on_file_drop(
- self, _target: Gtk.DropTarget, value: Gdk.FileList, _x: float, _y:
float
+ self, _target: Gtk.DropTarget, value: Gdk.FileList | None, _x: float,
_y: float
) -> bool:
+ if value is None:
+ log.debug("Drop received, but value is None")
+ return False
+
files = value.get_files()
if not files:
return False
=====================================
gajim/gtk/file_transfer_selector.py
=====================================
@@ -207,8 +207,12 @@ def _on_drop_accept(self, _target: Gtk.DropTarget, drop:
Gdk.Drop) -> bool:
return bool(formats.contain_gtype(Gdk.FileList))
def _on_file_drop(
- self, _target: Gtk.DropTarget, value: Gdk.FileList, _x: float, _y:
float
+ self, _target: Gtk.DropTarget, value: Gdk.FileList | None, _x: float,
_y: float
) -> bool:
+ if value is None:
+ log.debug("Drop received, but value is None")
+ return False
+
files = value.get_files()
if not files:
return False
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/282321eda6ad233ce2edd16c4f32e146db380a85
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/282321eda6ad233ce2edd16c4f32e146db380a85
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
