Daniel Brötzmann pushed to branch master at gajim / gajim
Commits:
238c18e5 by wurstsalat at 2024-12-22T23:40:49+01:00
cfix: AppSideBar: Use SignalManager
- - - - -
f75a9de1 by wurstsalat at 2024-12-22T23:43:17+01:00
cfix: AppPage: Disconnect settings signals
- - - - -
1c63f216 by wurstsalat at 2024-12-22T23:50:01+01:00
cfix: ApplyButtonBox: Fix resetting color classes
- - - - -
3 changed files:
- gajim/gtk/app_page.py
- gajim/gtk/app_side_bar.py
- gajim/gtk/apply_button_box.py
Changes:
=====================================
gajim/gtk/app_page.py
=====================================
@@ -94,6 +94,9 @@ def __init__(self) -> None:
app.settings.connect_signal("last_update_check", self._on_update_check)
+ def do_unroot(self) -> None:
+ app.settings.disconnect_signals(self)
+
def add_app_message(
self,
category: str,
=====================================
gajim/gtk/app_side_bar.py
=====================================
@@ -8,18 +8,21 @@
from gajim.common import app
from gajim.gtk.app_page import AppPage
+from gajim.gtk.util import SignalManager
-class AppSideBar(Gtk.ListBox):
+class AppSideBar(Gtk.ListBox, SignalManager):
def __init__(self, app_page: AppPage) -> None:
- Gtk.ListBox.__init__(self)
- self.set_valign(Gtk.Align.START)
- self.set_selection_mode(Gtk.SelectionMode.SINGLE)
+ Gtk.ListBox.__init__(
+ self, valign=Gtk.Align.START,
selection_mode=Gtk.SelectionMode.SINGLE
+ )
+ SignalManager.__init__(self)
+
self.add_css_class("workspace-sidebar")
- self.connect("row-activated", self._on_app_row_activated)
+ self._connect(self, "row-activated", self._on_app_row_activated)
- app_page.connect("unread-count-changed", self._on_unread_count_changed)
+ self._connect(app_page, "unread-count-changed",
self._on_unread_count_changed)
self._app_row = AppRow()
self.append(self._app_row)
@@ -27,6 +30,10 @@ def __init__(self, app_page: AppPage) -> None:
# Use idle_add to unselect listbox selection on startup
GLib.idle_add(self.unselect_all)
+ def do_unroot(self) -> None:
+ self._disconnect_all()
+ app.check_finalize(self)
+
@staticmethod
def _on_app_row_activated(_listbox: Gtk.ListBox, _row: Gtk.ListBoxRow) ->
None:
app.window.show_app_page()
=====================================
gajim/gtk/apply_button_box.py
=====================================
@@ -61,6 +61,9 @@ def set_error(self, tooltip_text: str):
self._button.set_sensitive(True)
def _set_status_image(self, state: str, tooltip_text: str = "") -> None:
+ self._status_image.remove_css_class("success-color")
+ self._status_image.remove_css_class("warning-color")
+
icon_name = "feather-check-symbolic"
css_class = "success-color"
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/7f31d9f3a3362b6badce36889724c37e23384a56...1c63f21683a178f6c01f639fc42a66a2f64f68cc
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/7f31d9f3a3362b6badce36889724c37e23384a56...1c63f21683a178f6c01f639fc42a66a2f64f68cc
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
