Daniel Brötzmann pushed to branch master at gajim / gajim


Commits:
17b8a96b by wurstsalat at 2024-11-24T15:14:16+01:00
cfix: Preview: Add temporary workaround for size update issues in scrolledview

- - - - -


2 changed files:

- gajim/gtk/conversation/view.py
- gajim/gtk/preview.py


Changes:

=====================================
gajim/gtk/conversation/view.py
=====================================
@@ -528,9 +528,6 @@ def add_message_from_db(self, message: Message) -> None:
     def _insert_message(self, message: BaseRow) -> None:
         self._list_box.append(message)
 
-        # TODO: This is a workaround to make the scrolledwindow aware of the 
new row
-        GLib.idle_add(message.queue_resize)
-
         self._add_date_row(message.timestamp)
         self._check_for_merge(message)
         assert self._read_marker_row is not None
@@ -539,6 +536,10 @@ def _insert_message(self, message: BaseRow) -> None:
             if message.timestamp > self._read_marker_row.timestamp:
                 self._read_marker_row.hide()
 
+        # TODO GTK4:
+        # This is a workaround to make the scrolledwindow aware of new content
+        GLib.idle_add(message.queue_resize)
+
     def _add_date_row(self, timestamp: datetime) -> None:
         start_of_day = get_start_of_day(timestamp.astimezone())
         if start_of_day in self._active_date_rows:


=====================================
gajim/gtk/preview.py
=====================================
@@ -150,6 +150,10 @@ def update(self, preview: Preview, data: bytes | None) -> 
None:
             self._ui.file_size.set_text(text)
             self._ui.image_button.set_tooltip_text(_("Location at %s") % text)
             self._ui.preview_box.set_size_request(160, -1)
+
+            # TODO GTK4:
+            # This is a workaround to make the scrolledwindow aware of new 
content
+            self._ui.preview_box.queue_resize()
             return
 
         self._ui.image_button.set_tooltip_text(preview.filename)
@@ -278,6 +282,10 @@ def update(self, preview: Preview, data: bytes | None) -> 
None:
         self._ui.file_name.set_text(preview.filename)
         self._ui.file_name.set_tooltip_text(preview.filename)
 
+        # TODO GTK4:
+        # This is a workaround to make the scrolledwindow aware of new content
+        GLib.idle_add(self.queue_resize)
+
     def _on_download(self, _button: Gtk.Button) -> None:
         if self._preview is None:
             return



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/17b8a96b9742d961e34ca58d8cd8022619e90c36

-- 
View it on GitLab: 
https://dev.gajim.org/gajim/gajim/-/commit/17b8a96b9742d961e34ca58d8cd8022619e90c36
You're receiving this email because of your account on dev.gajim.org.


_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to