Daniel Brötzmann pushed to branch gtk4 at gajim / gajim
Commits:
d918e9d4 by wurstsalat at 2024-10-27T15:34:27+01:00
refactor: ReadMarkerRow: Fix showing marker
- - - - -
73e9ce72 by wurstsalat at 2024-10-27T15:34:56+01:00
refactor: Remove obsolete TODOs
- - - - -
4 changed files:
- gajim/gtk/conversation/rows/read_marker.py
- gajim/gtk/conversation/rows/widgets.py
- gajim/gtk/conversation/view.py
- gajim/gtk/message_actions_box.py
Changes:
=====================================
gajim/gtk/conversation/rows/read_marker.py
=====================================
@@ -50,9 +50,7 @@ def set_timestamp(self, timestamp: datetime, force: bool =
False) -> None:
self.timestamp = timestamp
self.changed()
- # TODO GTK4
- # self.set_no_show_all(False)
- # self.show_all()
+ self.show()
def set_last_incoming_timestamp(self, timestamp: datetime) -> None:
if timestamp > self._last_incoming_timestamp:
=====================================
gajim/gtk/conversation/rows/widgets.py
=====================================
@@ -530,7 +530,6 @@ def _show_participant_menu(self, nick: str, x: float, y:
float) -> None:
self._contact.account, self_contact, contact
)
- # TODO GTK4: Menu moves content of adjacent widgets
self._menu_popover.set_menu_model(menu)
self._menu_popover.set_pointing_to_coord(x, y)
self._menu_popover.popup()
=====================================
gajim/gtk/conversation/view.py
=====================================
@@ -13,9 +13,10 @@
from datetime import datetime
from datetime import timedelta
-from gi.repository import Gio, Graphene
+from gi.repository import Gio
from gi.repository import GLib
from gi.repository import GObject
+from gi.repository import Graphene
from gi.repository import Gtk
from nbxmpp.errors import StanzaError
from nbxmpp.protocol import JID
@@ -122,7 +123,6 @@ def __init__(self, message_row_actions: MessageRowActions)
-> None:
self._signal_handler_ids = (0, 0)
self.set_child(self._list_box)
- # self.set_focus_vadjustment(Gtk.Adjustment()) TODO GTK4
app.window.get_action('scroll-view-up').connect(
'activate', self._on_scroll_view)
=====================================
gajim/gtk/message_actions_box.py
=====================================
@@ -216,7 +216,6 @@ def _on_action(self,
self._on_format(action_name)
elif action_name == 'show-emoji-chooser':
- # TODO GTK4
self.msg_textview.emit('insert-emoji')
self._ui.emoticons_button.set_active(False)
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/90428b50b9cf44533d3aefc56bc7397e838a5343...73e9ce726cbe6dfaba9407044d89dbae202020f7
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/compare/90428b50b9cf44533d3aefc56bc7397e838a5343...73e9ce726cbe6dfaba9407044d89dbae202020f7
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
