BaldDemian opened a new pull request, #3735:
URL: https://github.com/apache/fory/pull/3735

   ## Why?
   
   The C++ compiler should correctly apply ref pointer options for nested 
container element/value references.
   
   **Additional note**: 
   
   When submitting [PR 3731](https://github.com/apache/fory/pull/3731), I did 
not notice that Fory currently only supports nested collection types in C++: 
   
   
https://github.com/apache/fory/blob/33b0d6e8b73d1769d98824195b9155043266f3fe/docs/compiler/schema-idl.md?plain=1#L1414-L1418
   
   However, since that PR merely added a piece of defensive programming logic, 
it may not need to be reverted.
   
   Similar issues also exist in the Python and JavaScript compilers. However, 
since they do not support nested container types, I have not fixed them for now.
   
   ## What does this PR do?
   
   - Handle nested container ref pointer options correctly.
   - Add corresponding testcase.
   
   ## Related issues
   
   N/A.
   
   ## AI Contribution Checklist
   
   <!-- Full requirements and disclosure template:
   
https://github.com/apache/fory/blob/main/AI_POLICY.md#9-contributor-checklist-for-ai-assisted-prs
 -->
   
   - [ ] Substantial AI assistance was used in this PR: `no`
   - [ ] If `yes`, I included a completed [AI Contribution 
Checklist](https://github.com/apache/fory/blob/main/AI_POLICY.md#9-contributor-checklist-for-ai-assisted-prs)
 in this PR description and the required `AI Usage Disclosure`.
   - [ ] If `yes`, my PR description includes the required `ai_review` summary 
and screenshot evidence of the final clean AI review results from both fresh 
reviewers on the current PR diff or current HEAD after the latest code changes.
   
   <!-- If substantial AI assistance = `yes`, paste the completed checklist and 
disclosure block here, including the final ai_review summary and screenshot 
evidence from both fresh reviewers on the current PR diff or current HEAD after 
the latest code changes. -->
   
   ## Does this PR introduce any user-facing change?
   
   N/A.
   
   ## Benchmark
   
   N/A.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to