xhzq233 commented on PR #3669: URL: https://github.com/apache/fory/pull/3669#issuecomment-4427196562
@chaokunyang Thanks for the review. I have added a regression test in javascript/test/typemeta.test.ts: - test name: regenerated read serializers keep getTypeInfo - assertion: regenerateReadSerializer(...) returns a serializer with getTypeInfo available for named structs Local verification command: npm --prefix javascript run test -- typemeta.test.ts And I also verified fail/pass behavior: - on upstream main without this fix: this test fails (Expected function, Received undefined) - on this PR branch with fix: this test passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
