chaokunyang commented on code in PR #3613:
URL: https://github.com/apache/fory/pull/3613#discussion_r3136862190
##########
go/fory/buffer_test.go:
##########
@@ -81,3 +81,33 @@ func checkVarintWrite(t *testing.T, buf *ByteBuffer, value
int32) {
require.Equal(t, buf.ReaderIndex(), buf.WriterIndex())
require.Equal(t, value, varInt)
}
+
+// TestUnsafePutVarUint32PhysicalWriteWidth verifies that UnsafePutVarUint32
performs
+// an 8-byte physical write for 5-byte varints and that Reserve(8) (as
required by
+// buffer.go:661) keeps those 8 bytes within the backing array.
+func TestUnsafePutVarUint32PhysicalWriteWidth(t *testing.T) {
Review Comment:
Please add another test to cover struct.go change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
