ayush00git commented on PR #3600: URL: https://github.com/apache/fory/pull/3600#issuecomment-4294323288
> No, that still doesn't fory dart on web work. It's just avoid real issue. @chaokunyang making `dart test -p chrome` fully pass on `buffer_test.dart` requires a larger fix that is adding BigInt-based fallbacks to the raw 64-bit read/write methods in `buffer.dart` and `generated_support.dart`, plus rewriting the affected test literals. Should I keep the scope of current PR only for the `writeVarInt64` fix, and for this bug open an issue and then start working on it in a new PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
