miantalha45 commented on code in PR #3564: URL: https://github.com/apache/fory/pull/3564#discussion_r3114802390
########## dart/packages/fory/lib/src/types/bfloat16.dart: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import 'dart:typed_data'; + +/// Brain floating-point (bfloat16) wrapper used by the xlang type system. +/// +/// BFloat16 uses 1 sign bit, 8 exponent bits, and 7 mantissa bits. +/// It has the same exponent range as float32 but with reduced precision. +final class BFloat16 implements Comparable<BFloat16> { Review Comment: > And please also rename for > > ``` > /// Unsigned 8-bit integer wrapper used by the xlang type system. > final class UInt8 extends _FixedInt { > /// Creates a normalized unsigned 8-bit value. > UInt8(int value) : super(value.toUnsigned(8)); > } > > /// Unsigned 16-bit integer wrapper used by the xlang type system. > final class UInt16 extends _FixedInt { > /// Creates a normalized unsigned 16-bit value. > UInt16(int value) : super(value.toUnsigned(16)); > } > > /// Unsigned 32-bit integer wrapper used by the xlang type system. > final class UInt32 extends _FixedInt { > /// Creates a normalized unsigned 32-bit value. > UInt32(int value) : super(value.toUnsigned(32)); > } > ``` because you ask me to rename this, so that's why i changes _FixedInt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
