The GitHub Actions job "Fory CI" on fory.git/main has succeeded. Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run: b4d7ad3b9c658ee36df093f1ac6f9db552ae601f / Ayush Kumar <[email protected]> fix(dart): use getUint32 for correctly encoding u64 value (#3592) ## Why? `getInt32` treats the top bit as a sign bit. For large values where that bit is set (0xFFFFFFFE), the number comes back negative. Even though >>> is unsigned shift, it is shifting the already-corrupted signed value, garbage in, garbage out. ## What does this PR do? Use `getUint32` instead. `getUint32` has no sign bit, so all 32 bits are treated as magnitude. ## Related issues N/A ## AI Contribution Checklist - [ ] Substantial AI assistance was used in this PR: `yes` / `no` - [ ] If `yes`, I included a completed [AI Contribution Checklist](https://github.com/apache/fory/blob/main/AI_POLICY.md#9-contributor-checklist-for-ai-assisted-prs) in this PR description and the required `AI Usage Disclosure`. - [ ] If `yes`, my PR description includes the required `ai_review` summary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes. ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark Report URL: https://github.com/apache/fory/actions/runs/24670561876 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
