chaokunyang commented on code in PR #3592:
URL: https://github.com/apache/fory/pull/3592#discussion_r3110729687
##########
dart/packages/fory/lib/src/buffer.dart:
##########
@@ -402,7 +402,7 @@ final class Buffer {
/// Reads an unsigned 64-bit integer written by [writeTaggedUint64].
int readTaggedUint64() {
final readIndex = _readerIndex;
- final first = _view.getInt32(readIndex, Endian.little);
+ final first = _view.getUint32(readIndex, Endian.little);
Review Comment:
This fixes `Buffer.readTaggedUint64()`, but
`GeneratedReadCursor.readTaggedUint64()` in
`dart/packages/fory/lib/src/codegen/generated_support.dart` still reads the
first word with `getInt32`. Generated serializers route tagged `uint64` fields
through that cursor path, so `0x7fffffff` still round-trips there as
`9223372036854775807` instead of `2147483647`. The generated path needs the
same `getUint32` change and a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
