Youmanvi commented on issue #3506: URL: https://github.com/apache/fory/issues/3506#issuecomment-4245134522
Hey I've been digging into CollectionSerializer.__init__ in collection.pxi / collection.py, and I think I see what’s happening. It looks like the elem_serializer is None branch might be unconditionally setting self.elem_tracking_ref = -1, which effectively ignores the elem_tracking_ref=False override from the annotation. I would be super excited to work on a fix for this! Would it be alright if I submitted a PR with the following validation plan? Unit Test: A List[Ref[T, False]] roudntrip test to ensure aliased instances are not deduplicated when tracking is disabled. Byte-level Check: Asserting that the COLL_TRACKING_REF bit is unset in the serialized output. Does that sound like it would fit the project's testing standards? I was also curious if I should run the resulting bytes through the Rust deserializer via the cross-language harness to ensure parity (mainly if that would be a helpful addition)? As this would be my first contribution to the repo, I'd appreciate any guidance on whether this approach aligns with your expectations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
