meonkeys commented on code in PR #54:
URL: https://github.com/apache/fineract-site/pull/54#discussion_r2874561404
##########
css/fineract.css:
##########
@@ -142,14 +251,21 @@ html {
font-family: "Open Sans Condensed";
}
-.logo {
- margin: 5px 0px;
- height: 55px;
+.side-nav-header .logo {
+ height: 32px !important;
+ width: auto !important;
+ margin: 0 !important;
+ display: block !important;
Review Comment:
Can you do this without all the `!important` flags? This is [bad
practice](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/important#best_practices)
##########
index.html:
##########
@@ -1,5 +1,5 @@
-<!doctype html><html lang=en><head><meta charset=UTF-8><meta name=viewport
content="width=device-width,initial-scale=1"><title>Apache
Fineract®</title><link rel=icon type=image/png
href=images/apache-fineract-icon.png><link href=css/material-icons.css
type=text/css rel=stylesheet><link href=css/materialize.min.css type=text/css
rel=stylesheet><link href=css/nav-styles.css type=text/css rel=stylesheet><link
href=css/fineract.css type=text/css rel=stylesheet></head><body id=top
class="ghost-white jet-text"><header><div class=navbar-fixed><nav class="jet
ghost-white-text" aria-label="Main navigation"><div class=nav-wrapper><div
class=container><a href=#top class=brand-logo><div class=logo-wrapper><div
class=logo-container><img class=logo-img src=images/apache-fineract-logo.png
alt="Apache Fineract® Logo"><div class=brand-text><span class=brand-name>Apache
Fineract®</span></div></div></div></a><a href=# data-activates=mobile-menu
class=button-collapse aria-label="Open menu"><i class=
material-icons>menu</i></a><ul class="right hide-on-med-and-down nav-links"
role=list><li><a class=nav-link href=#about><i class="material-icons left"
aria-hidden=true>info</i>About</a></li><li><a class=nav-link
href=#contribute><i class="material-icons left"
aria-hidden=true>people</i>Contribute</a></li><li><a class=nav-link
href=#downloads><i class="material-icons left"
aria-hidden=true>download</i>Downloads</a></li><li><a class=nav-link
href=#resources><i class="material-icons left"
aria-hidden=true>library_books</i>Resources</a></li><li><a class=nav-link
href=#reference><i class="material-icons left"
aria-hidden=true>link</i>Reference</a></li><li><a class="nav-link theme-toggle"
href=# onclick=toggleTheme() aria-label="Toggle theme"><i
class=material-icons>dark_mode</i></a></li></ul><ul class="side-nav ghost-white
jet-text" id=mobile-menu role=list><li class=side-nav-header><div
class=logo-container><img class=logo src=images/apache-fineract-logo.png
alt="Fineract® Logo">
Review Comment:
why is this file changing?
##########
css/security.css:
##########
@@ -36,7 +36,7 @@ strong {
}
a {
- color: #26a69a;
+ color: #00796B;
Review Comment:
ping
##########
css/fineract.css:
##########
@@ -378,33 +543,84 @@ main.container .collection .collection-item:last-child,
#contribute .collection-item .title {
margin-top: 0;
- color: #26a69a;
+ color: var(--link-color);
+}
+
+#contribute .grey-text,
+#contribute .collection-item .grey-text,
+#contribute p.grey-text {
+ color: var(--text-color) !important;
+ opacity: 0.7;
}
#contribute .mailing-actions {
- margin-top: 10px;
+ margin-top: 6px;
}
#contribute .mailing-actions .btn-small {
- margin-right: 10px;
+ margin-right: 2px;
+ padding: 0 8px;
+ display: inline-flex !important;
+ align-items: center !important;
+ gap: 2px;
+}
+
+#contribute .mailing-actions .btn-small i.left {
+ float: none !important;
+ margin-right: 0 !important;
+ margin-left: 0 !important;
}
#contribute .chip {
height: fit-content;
}
-#contribute .collection-item .chip {
+#contribute .collection-item .chip,
+#contribute .chip {
max-width: 100%;
word-break: break-all;
overflow-wrap: anywhere;
+ padding: 0 8px !important;
+ margin: 0 !important;
+ height: auto !important;
+ min-height: 32px;
+ line-height: 32px !important;
+ font-size: 0.95rem !important;
+ background-color: #e0e0e0 !important;
+ display: inline-flex !important;
+ align-items: center !important;
}
-#contribute .collection-item .chip i {
+#contribute .collection-item .chip i,
+#contribute .chip i {
flex-shrink: 0;
+ line-height: 32px;
+ color: #005D50 !important;
+ float: none !important;
+ margin-right: 2px !important;
+ margin-left: 0 !important;
+ font-size: 0.9rem !important;
+}
+
+#contribute .chip .material-icons.left {
+ float: none !important;
+ margin-left: 0 !important;
+ margin-right: 2px !important;
+}
+
+[data-theme="dark"] #contribute .collection-item .chip,
+[data-theme="dark"] #contribute .chip {
+ background-color: #3a3a3a !important;
+ color: #e0e0e0 !important;
+}
+
+[data-theme="dark"] #contribute .collection-item .chip i,
+[data-theme="dark"] #contribute .chip i {
+ color: #4db6ac !important;
Review Comment:
same thought re: `!important` flags here (and throughout the patch). As I
understand it, `!important` should rarely be used. Please correct me if I'm
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
