edk12564 opened a new pull request, #5570: URL: https://github.com/apache/fineract/pull/5570
JIRA: FINERACT-2165 ## Changes CurrenciesTest utilized the low level RestAssured client and JUnit. According to the guidelines in the Fineract community and FINERACT-2165, I replaced these tests with equivalent tests in Cucumber and Gherkin. More details below. - Eliminated old CurrenciesTest, CurrenciesHelper, and CurrencyDomain due to implementing RestAssured client and JUnit - Created test steps with Feign Client and feature file with Gherkin that covers same test cases as old tests but now located in E2E-core and E2E-runner and updated tooling. - Updated ErrorMessageHelper to handle Currency error logging. - Fixed bug in CenterDomain.java that was causing compilation issues. CurrenciesDomain was improperly being imported and not used anywhere. ## Results Tests pass with the latest version of the codebase. <img width="1653" height="474" alt="Screenshot 2026-03-01 at 6 53 16 PM" src="https://github.com/user-attachments/assets/1e6db489-21de-4b25-bd27-df0ec4144dba"; /> ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
