Aman-Mittal commented on code in PR #4979:
URL: https://github.com/apache/fineract/pull/4979#discussion_r2310454894
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -142,20 +142,20 @@ public static Charge fromJson(final JsonCommand command,
final GLAccount account
final String currencyCode =
command.stringValueOfParameterNamed("currencyCode");
final ChargeAppliesTo chargeAppliesTo =
ChargeAppliesTo.fromInt(command.integerValueOfParameterNamed("chargeAppliesTo"));
- final ChargeTimeType chargeTimeType =
ChargeTimeType.fromInt(command.integerValueOfParameterNamed("chargeTimeType"));
+ final ChargeTimeType chargeTimeType =
ChargeTimeType.fromInt(command.integerValueOfParameterNamed(CHARGE_TIME_PARAM_NAME));
final ChargeCalculationType chargeCalculationType =
ChargeCalculationType
-
.fromInt(command.integerValueOfParameterNamed("chargeCalculationType"));
+
.fromInt(command.integerValueOfParameterNamed(CHARGE_CALCULATION_TIME_PARAM_NAME));
final Integer chargePaymentMode =
command.integerValueOfParameterNamed("chargePaymentMode");
final ChargePaymentMode paymentMode = chargePaymentMode == null ? null
: ChargePaymentMode.fromInt(chargePaymentMode);
final boolean penalty =
command.booleanPrimitiveValueOfParameterNamed("penalty");
final boolean active =
command.booleanPrimitiveValueOfParameterNamed("active");
- final MonthDay feeOnMonthDay =
command.extractMonthDayNamed("feeOnMonthDay");
- final Integer feeInterval =
command.integerValueOfParameterNamed("feeInterval");
+ final MonthDay feeOnMonthDay =
command.extractMonthDayNamed(FEE_ON_MONTH_DAT_PARAM_NAME);
Review Comment:
Fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
