adamsaghy commented on code in PR #4939:
URL: https://github.com/apache/fineract/pull/4939#discussion_r2306733966
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/service/TaxReadPlatformServiceImpl.java:
##########
@@ -52,7 +52,8 @@ public class TaxReadPlatformServiceImpl implements
TaxReadPlatformService {
@Override
public List<TaxComponentData> retrieveAllTaxComponents() {
String sql = "select " + TAX_COMPONENT_MAPPER.getSchema();
- return this.jdbcTemplate.query(sql, TAX_COMPONENT_MAPPER); // NOSONAR
+ return this.jdbcTemplate.query(con -> con.prepareStatement(sql,
ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_UPDATABLE),
Review Comment:
I am not convinced we need `ResultSet.TYPE_SCROLL_INSENSITIVE,
ResultSet.CONCUR_UPDATABLE)`, this services just retrieve a List of
TaxComponentData AS-IS, no any iteration on them back or forth...
Can you help me to understand why this is an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
