adamsaghy commented on code in PR #4916:
URL: https://github.com/apache/fineract/pull/4916#discussion_r2272927909
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -689,8 +689,6 @@ public LoanTransaction creditBalanceRefund(final Loan loan,
final LocalDate tran
loanRefundService.creditBalanceRefund(loan,
newCreditBalanceRefundTransaction, existingTransactionIds,
existingReversedTransactionIds);
- newCreditBalanceRefundTransaction =
this.loanTransactionRepository.saveAndFlush(newCreditBalanceRefundTransaction);
Review Comment:
If this transaction is not flushed, in the `businessEventNotifierService
.notifyPostBusinessEvent(new
LoanCreditBalanceRefundPostBusinessEvent(newCreditBalanceRefundTransaction));`
we wont have id...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
