This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
from c84ba089f0 Revert "FINERACT-2181: Fix overdue balance updates in
advanced payment schedu…"
new 6d65f07924 FINERACT-2317: Add support for modifying loan approved
amounts with validation and history tracking
new ecbefb04c4 FINERACT-2317: Added e2e tests covering support for
modifying loan approved amounts with validation and history tracking
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../commands/service/CommandWrapperBuilder.java | 9 +
.../portfolio/common/service/Validator.java | 23 +-
.../test/data/loanproduct/DefaultLoanProduct.java | 2 +
.../fineract/test/helper/ErrorMessageHelper.java | 14 +-
.../apache/fineract/test/helper/ErrorResponse.java | 9 +
.../global/LoanProductGlobalInitializerStep.java | 61 +++
.../fineract/test/stepdef/loan/LoanStepDef.java | 125 ++++++
.../fineract/test/support/TestContextKey.java | 2 +
.../src/test/resources/features/Loan.feature | 161 +++++++
...=> LoanApprovedAmountChangedBusinessEvent.java} | 6 +-
.../data/LoanApprovedAmountHistoryData.java | 23 +-
.../domain/LoanApprovedAmountHistory.java | 20 +-
...va => LoanApprovedAmountHistoryRepository.java} | 23 +-
...nApprovedAmountModificationCommandHandler.java} | 16 +-
.../serialization/LoanApprovedAmountValidator.java | 7 +-
.../LoanApprovedAmountWritePlatformService.java | 7 +-
...LoanApprovedAmountWritePlatformServiceImpl.java | 76 ++++
.../module/fineract-loan/persistence.xml | 1 +
.../loanaccount/api/LoansApiResource.java | 69 +++
.../loanaccount/api/LoansApiResourceSwagger.java | 43 ++
.../serialization/LoanApplicationValidator.java | 25 +-
.../LoanApprovedAmountValidatorImpl.java | 104 +++++
.../serialization/LoanDisbursementValidator.java | 2 +-
.../LoanTransactionValidatorImpl.java | 2 +-
.../service/LoanDisbursementService.java | 1 +
.../starter/LoanAccountConfiguration.java | 2 +-
.../db/changelog/tenant/changelog-tenant.xml | 2 +
..._add_LoanApprovedAmountChangedBusinessEvent.xml | 2 +-
...> 0192_create_loan_approved_amount_history.xml} | 66 +--
...nalEventConfigurationValidationServiceTest.java | 4 +-
.../integrationtests/BaseLoanIntegrationTest.java | 12 +
.../LoanModifyApprovedAmountTests.java | 481 +++++++++++++++++++++
.../common/ExternalEventConfigurationHelper.java | 5 +
.../common/loans/LoanTestLifecycleExtension.java | 9 +
34 files changed, 1299 insertions(+), 115 deletions(-)
copy
fineract-loan/src/main/java/org/apache/fineract/infrastructure/event/business/domain/loan/{LoanInterestRecalculationBusinessEvent.java
=> LoanApprovedAmountChangedBusinessEvent.java} (83%)
copy
fineract-branch/src/main/java/org/apache/fineract/organisation/teller/data/CashierTransactionTypeTotalsData.java
=>
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanApprovedAmountHistoryData.java
(64%)
copy
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferLoanMapping.java
=>
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanApprovedAmountHistory.java
(68%)
copy
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/{LoanChargeRepository.java
=> LoanApprovedAmountHistoryRepository.java} (59%)
copy
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/handler/{GLIMApplicationRejectionCommandHandler.java
=> LoanApprovedAmountModificationCommandHandler.java} (75%)
copy
fineract-core/src/main/java/org/apache/fineract/commands/handler/NewCommandSourceHandler.java
=>
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApprovedAmountValidator.java
(79%)
copy
fineract-accounting/src/main/java/org/apache/fineract/accounting/accrual/service/AccrualAccountingWritePlatformService.java
=>
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApprovedAmountWritePlatformService.java
(82%)
mode change 100755 => 100644
create mode 100644
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApprovedAmountWritePlatformServiceImpl.java
create mode 100644
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApprovedAmountValidatorImpl.java
copy
fineract-loan/src/main/resources/db/changelog/tenant/module/loan/parts/1030_add_loan_undo_contract_termination_event.xml
=>
fineract-provider/src/main/resources/db/changelog/tenant/parts/0191_add_LoanApprovedAmountChangedBusinessEvent.xml
(94%)
copy
fineract-provider/src/main/resources/db/changelog/tenant/parts/{0188_create_loan_buy_down_fee_balance.xml
=> 0192_create_loan_approved_amount_history.xml} (52%)
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanModifyApprovedAmountTests.java
