mariiaKraievska commented on code in PR #4800:
URL: https://github.com/apache/fineract/pull/4800#discussion_r2189149123
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/SingleLoanChargeRepaymentScheduleProcessingWrapper.java:
##########
@@ -143,13 +139,12 @@ private Money calcChargeDue(final LocalDate periodStart,
final LocalDate periodE
}
private Money calcChargeWaived(final LocalDate periodStart, final
LocalDate periodEnd, final LoanCharge loanCharge,
- final MonetaryCurrency currency, boolean
isInstallmentChargeApplicable, boolean isFirstPeriod,
- Predicate<LoanCharge> predicate) {
+ final MonetaryCurrency currency, boolean isFirstPeriod,
Predicate<LoanCharge> predicate) {
Money zero = Money.zero(currency);
if (!predicate.test(loanCharge)) {
return zero;
}
- if (loanCharge.isInstalmentFee() && isInstallmentChargeApplicable) {
Review Comment:
I have reverted this change, since we agreed to disallow installment fee
charges that are calculated as a percentage of principal or interest when
interest recalculation is enabled.
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanChargeApiJsonValidator.java:
##########
@@ -264,16 +264,8 @@ public void validateLoanCharges(final Set<LoanCharge>
charges, final List<ApiPar
for (LoanCharge loanCharge : charges) {
String errorcode = null;
switch (loanCharge.getChargeCalculation()) {
- case PERCENT_OF_AMOUNT:
Review Comment:
I have reverted this change, since we agreed to disallow installment fee
charges that are calculated as a percentage of principal or interest when
interest recalculation is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
