adamsaghy commented on code in PR #4752:
URL: https://github.com/apache/fineract/pull/4752#discussion_r2137244278


##########
fineract-document/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -77,6 +82,8 @@ public Long createDocument(final DocumentCommand 
documentCommand, final InputStr
                     documentCommand.getName(), documentCommand.getFileName(), 
documentCommand.getSize(), documentCommand.getType(),
                     documentCommand.getDescription(), fileLocation, 
contentRepository.getStorageType());
 
+            businessEventNotifierService.notifyPostBusinessEvent(new 
DocumentCreatedBusinessEvent(document));

Review Comment:
   If you throw the business event before it got saved, there will be NO 
primary key!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to