adamsaghy commented on code in PR #4750:
URL: https://github.com/apache/fineract/pull/4750#discussion_r2137232486
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/adjustment/LoanAdjustmentServiceImpl.java:
##########
@@ -213,14 +217,16 @@ public CommandProcessingResult adjustLoanTransaction(Loan
loan, LoanTransaction
this.loanTransactionRepository.saveAndFlush(newTransactionDetail);
}
- if (capitalizedIncomeAmortizationAdjustmentTransaction != null &&
capitalizedIncomeAmortizationAdjustmentTransaction.isNotZero()) {
- LoanTransaction
savedCapitalizedIncomeAmortizationAdjustmentTransaction =
loanTransactionRepository
-
.saveAndFlush(capitalizedIncomeAmortizationAdjustmentTransaction);
-
loan.addLoanTransaction(savedCapitalizedIncomeAmortizationAdjustmentTransaction);
- businessEventNotifierService
- .notifyPostBusinessEvent(new
LoanCapitalizedIncomeAmortizationAdjustmentTransactionCreatedBusinessEvent(
-
capitalizedIncomeAmortizationAdjustmentTransaction));
- }
+ // TODO remove
Review Comment:
Remove if not needed
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/adjustment/LoanAdjustmentServiceImpl.java:
##########
@@ -156,9 +155,13 @@ public CommandProcessingResult adjustLoanTransaction(Loan
loan, LoanTransaction
throw new InvalidLoanTransactionTypeException("transaction",
"capitalizedIncome.cannot.be.reversed.when.adjusted",
"Capitalized income transaction cannot be reversed
when non-reversed adjustment exists for it.");
}
- BigDecimal recognizedAmount =
capitalizedIncomeBalance.getAmount().subtract(capitalizedIncomeBalance.getUnrecognizedAmount());
- capitalizedIncomeAmortizationAdjustmentTransaction =
LoanTransaction.capitalizedIncomeAmortizationAdjustment(loan,
- Money.of(loan.getCurrency(), recognizedAmount),
DateUtils.getBusinessLocalDate(), externalIdFactory.create());
+ // TODO nem kell realtime amortization adjustment
Review Comment:
Remove if not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
