adamsaghy commented on code in PR #4709:
URL: https://github.com/apache/fineract/pull/4709#discussion_r2113916920


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -315,7 +319,10 @@ public CommandProcessingResult createClient(final 
JsonCommand command) {
                 extractAndCreateClientNonPerson(newClient, command);
             }
 
-            if (isAddressEnabled) {
+            ObjectMapper mapper = new ObjectMapper();

Review Comment:
   You guys are doing again... opening multiple PRs and having overlapping 
solutions. I am asking you once again.. Would you mind to open just one PR? I 
dont mind if you guys are having 2 commits if both of you want to be authors, 
but i really do mind to do PR review twice and replying comments twice...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to