adamsaghy commented on code in PR #4608:
URL: https://github.com/apache/fineract/pull/4608#discussion_r2056739188
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/fixeddeposits/FixedDepositTransactionWorkbookPopulator.java:
##########
@@ -203,7 +204,12 @@ private void populateSavingsTable(Sheet
savingsTransactionSheet, String dateForm
row = savingsTransactionSheet.createRow(rowIndex++);
writeString(TransactionConstants.LOOKUP_CLIENT_NAME_COL, row,
savingsAccount.getClientName() + "(" +
savingsAccount.getClientId() + ")");
- writeString(TransactionConstants.LOOKUP_ACCOUNT_NO_COL, row,
savingsAccount.getAccountNo());
+ try {
+ BigDecimal accountNoAsBigDecimal = new
BigDecimal(savingsAccount.getAccountNo());
Review Comment:
Account number is a string... just because usually they store a number in
it, it is a string... I dont really understand what means "The problem is that
when I put the account number as a string in the Excel formulas, it's not
working correctly"... what is not working? What are you trying to achieve? what
problem occurs? etc.
If you must have a number still BigDecimal is not the way to go... you can
give a try to Long then... but still... in Fineract the account number is
string... usually it is a whole number, but not necessarily... also "0001" is a
valid account number which will be "1" if you try to convert it to Long... and
"1" is not equal to "0001".... so we are back to square one: account number is
string... and it is not a number...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
