adamsaghy commented on code in PR #4510:
URL: https://github.com/apache/fineract/pull/4510#discussion_r2048546082
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java:
##########
@@ -338,13 +338,6 @@ private void validateForCreate(final JsonElement element) {
baseDataValidator.reset().parameter(LoanApiConstants.externalIdParameterName).value(externalId).ignoreIfNull()
.notExceedingLengthOf(100);
}
-
- if
(this.fromApiJsonHelper.parameterExists(LoanApiConstants.fundIdParameterName,
element)) {
Review Comment:
This is a conditional if, if fundId was provided, it must be bigger than 0.
It does not check whether it is mandatory or not... please do not remove
conditional validations!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
