oleksma commented on code in PR #4465:
URL: https://github.com/apache/fineract/pull/4465#discussion_r2003654294
##########
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/data/FloatingRateData.java:
##########
@@ -18,34 +18,34 @@
*/
package org.apache.fineract.portfolio.floatingrates.data;
+import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
-import com.fasterxml.jackson.annotation.JsonProperty;
import java.io.Serializable;
import java.time.OffsetDateTime;
import java.util.List;
+import lombok.Getter;
import org.apache.commons.lang3.builder.CompareToBuilder;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.apache.fineract.infrastructure.core.data.EnumOptionData;
+@Getter
@JsonInclude(JsonInclude.Include.NON_NULL)
public class FloatingRateData implements Comparable<FloatingRateData>,
Serializable {
private final Long id;
private final String name;
- @JsonProperty("isBaseLendingRate")
- private final boolean isBaseLendingRate;
- @JsonProperty("isActive")
- private final boolean isActive;
+ private final Boolean isBaseLendingRate;
+ private final Boolean isActive;
private final String createdBy;
private final OffsetDateTime createdOn;
private final String modifiedBy;
private final OffsetDateTime modifiedOn;
private final List<FloatingRatePeriodData> ratePeriods;
- @SuppressWarnings("unused")
+ @JsonIgnore
Review Comment:
This field annotated
@JsonIgnore
List<EnumOptionData> interestRateFrequencyTypeOptions
Because this field was abcent in @ApiResponses in classes
FloatingRatesApiResourceSwagger.GetFloatingRatesResponse
FloatingRatesApiResourceSwagger.GetFloatingRatesFloatingRateIdResponse (was
removed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
