mariiaKraievska commented on code in PR #4446:
URL: https://github.com/apache/fineract/pull/4446#discussion_r1993273818
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/ChangedTransactionDetail.java:
##########
@@ -18,18 +18,61 @@
*/
package org.apache.fineract.portfolio.loanaccount.domain;
-import java.util.LinkedHashMap;
-import java.util.Map;
+import java.util.ArrayList;
+import java.util.List;
import lombok.Getter;
+import org.apache.fineract.portfolio.loanaccount.data.TransactionChangeData;
/**
* Stores details of {@link LoanTransaction}'s that were reversed or newly
created
*/
@Getter
public class ChangedTransactionDetail {
- private final Map<Long, LoanTransaction> newTransactionMappings = new
LinkedHashMap<>();
+ private final List<TransactionChangeData> transactionChanges = new
ArrayList<>();
- private final Map<LoanTransaction, Long> currentTransactionToOldId = new
LinkedHashMap<>();
+ /**
+ * Adds a new transaction without a corresponding reversed transaction
+ */
+ public void addNewTransaction(final LoanTransaction newTransaction) {
+ for (TransactionChangeData change : transactionChanges) {
+ if (change.getOldTransaction() != null &&
change.getNewTransaction().getId() != null
+ &&
change.getNewTransaction().getId().equals(newTransaction.getId())) {
+ change.setNewTransaction(newTransaction);
+ return;
+ }
+ }
+ transactionChanges.add(new TransactionChangeData(null,
newTransaction));
+ }
+ /**
+ * Adds a reverse-replay transaction mapping
+ */
+ public void addReversedTransaction(final LoanTransaction oldTransaction,
final LoanTransaction newTransaction) {
+ for (TransactionChangeData change : transactionChanges) {
+ if (change.getOldTransaction() != null &&
change.getOldTransaction().getId() != null
+ &&
change.getOldTransaction().getId().equals(oldTransaction.getId())) {
+ change.setOldTransaction(oldTransaction);
+ change.setNewTransaction(newTransaction);
+ return;
+ }
+ }
+ transactionChanges.add(new TransactionChangeData(oldTransaction,
newTransaction));
+ }
+
+ public void addTransactionChange(final TransactionChangeData
transactionChangeData) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
