(fineract) branch develop updated: FINERACT-2212: Savings interest was sometimes posted to the wrong GL accounts

[arnold]

This is an automated email from the ASF dual-hosted git repository.

arnold pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 91f0662998 FINERACT-2212: Savings interest was sometimes posted to the 
wrong GL accounts
91f0662998 is described below

commit 91f066299822e07de417460f705079e25961c081
Author: Arnold Galovics <galovicsarn...@gmail.com>
AuthorDate: Wed Mar 12 14:22:52 2025 +0100

    FINERACT-2212: Savings interest was sometimes posted to the wrong GL 
accounts
---
 .../savings/service/SavingsAccountReadPlatformServiceImpl.java      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformServiceImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformServiceImpl.java
index dcb7e534b6..46579b8a76 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformServiceImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformServiceImpl.java
@@ -382,8 +382,10 @@ public class SavingsAccountReadPlatformServiceImpl 
implements SavingsAccountRead
             sqlBuilder.append("left join m_tax_group tg on tg.id = 
sa.tax_group_id ");
             sqlBuilder.append("left join 
m_savings_account_transaction_tax_details txd on txd.savings_transaction_id = 
tr.id ");
             sqlBuilder.append("left join m_tax_component mtc on mtc.id = 
txd.tax_component_id ");
-            sqlBuilder.append("left join acc_product_mapping apm on 
apm.product_id = sp.id and apm.financial_account_type=3 ");
-            sqlBuilder.append("left join acc_product_mapping apm1 on 
apm1.product_id = sp.id and apm1.financial_account_type=2 ");
+            sqlBuilder.append(
+                    "left join acc_product_mapping apm on apm.product_type = 2 
and apm.product_id = sp.id and apm.financial_account_type=3 ");
+            sqlBuilder.append(
+                    "left join acc_product_mapping apm1 on apm1.product_type = 
2 and apm1.product_id = sp.id and apm1.financial_account_type=2 ");
 
             this.schemaSql = sqlBuilder.toString();
         }