somasorosdpc opened a new pull request, #4407: URL: https://github.com/apache/fineract/pull/4407
## Description Introduce new flag `days_in_year_custom_strategy` and calculations for values in case of Days In Years set to `ACTUAL`. * `FULL_LEAP_YEAR`: 366 days for full leap year. → This is the by default value! * `FEB_29_PERIOD_ONLY`: 366 days for period of February 29 * Introduce new field for loan and loan product * Implement calculations in `EMICalculator` * With covering unittest for EMI Calculator Check associated [Apache Fineract JIRA ticket](https://issues.apache.org/jira/browse/FINERACT-1982). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
