oleksii-novikov-onix commented on code in PR #4288:
URL: https://github.com/apache/fineract/pull/4288#discussion_r1936827106


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/ProgressiveLoanInterestScheduleModel.java:
##########
@@ -260,7 +260,7 @@ private void insertInterestPausePeriods(final 
RepaymentPeriod repaymentPeriod, f
 
         if (fromDate.isBefore(originalFromDate) && 
endDate.isBefore(originalDueDate)) {
             repaymentPeriod.getInterestPeriods().clear();

Review Comment:
   Fixed it, now our implementation will do the following:
    - Fully overlapped periods are removed.
    - Partially overlapped periods are truncated.
    - A new paused period is inserted in the correct chronological position.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to