adamsaghy commented on code in PR #3634:
URL: https://github.com/apache/fineract/pull/3634#discussion_r1426489275
##########
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java:
##########
@@ -218,7 +219,29 @@ public InteropTransactionsData
getAccountTransactions(@NotNull String accountId,
return (transactionsTo == null ||
transactionsTo.compareTo(transactionDate) > 0) && (transactionsFrom == null
||
transactionsFrom.compareTo(transactionDate.withHour(23).withMinute(59).withSecond(59))
<= 0);
};
- return InteropTransactionsData.build(savingsAccount, transFilter);
+ InteropTransactionsData interopTransactionsData =
InteropTransactionsData.build(savingsAccount, transFilter);
+ for (InteropTransactionData interopTransactionData :
interopTransactionsData.getTransactions()) {
+ final List<Note> transactionNotes = noteRepository
+
.findBySavingsTransactionId(Long.valueOf(interopTransactionData.getTransactionId()));
+ StringBuilder sb = new StringBuilder();
+ if (!transactionNotes.isEmpty()) {
Review Comment:
This if condition is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
