marta-jankovics commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1281648777
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java:
##########
@@ -58,10 +58,10 @@ public DatabaseType databaseType() {
}
public boolean isPostgreSQL() {
- return DatabaseType.POSTGRESQL.equals(currentDatabaseType.get());
+ return DatabaseType.POSTGRESQL == currentDatabaseType.get();
Review Comment:
These isX functions are not new and sometimes really useful, when you do not
want to know which enum(s) belong to a category.
For identity please see my previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
