galovics commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1275216677
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java:
##########
@@ -36,14 +42,26 @@ public DatabaseSpecificSQLGenerator(DatabaseTypeResolver
databaseTypeResolver) {
}
public String escape(String arg) {
- if (databaseTypeResolver.isMySQL()) {
+ return escape(databaseTypeResolver.databaseType(), arg);
+ }
+
+ public static String escape(DatabaseType dialect, String arg) {
+ if (dialect.isMySql()) {
return format("`%s`", arg);
- } else if (databaseTypeResolver.isPostgreSQL()) {
+ } else if (dialect.isPostgres()) {
return format("\"%s\"", arg);
}
return arg;
}
+ public String formatValue(JdbcJavaType columnType, String value) {
+ return formatValue(databaseTypeResolver.databaseType(), columnType,
value);
+ }
+
+ public static String formatValue(DatabaseType dialect, JdbcJavaType
columnType, String value) {
Review Comment:
I dont see that, the parameter is not even used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
