Mikkey-f commented on PR #1033: URL: https://github.com/apache/fesod/pull/1033#issuecomment-5644222014
Thanks for the review — all three are addressed in 7653c542 (test-only, no production code changed): 1. Added `stringConverterHonoursConfiguredLocale`, which pins `Locale.GERMAN` with a locale-sensitive pattern (`dd MMMM yyyy HH:mm:ss XXX`) and asserts both the written text and the round-trip read, so the locale is now actually exercised and independent of the machine default. 2. Added `test_parseOffsetDateTime` and `test_format_OffsetDateTime` to `DateUtilsTest`, following the cases you outlined. 3. Added the `@AfterEach tearDown()` calling `DateUtils.removeThreadLocalCache()`, matching the sibling converter tests. spotless and the full test suite (932 tests) are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
