This is an automated email from the ASF dual-hosted git repository.
delei pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fesod.git
The following commit(s) were added to refs/heads/main by this push:
new 470025de fix: avoid recursive hashCode in write holder contexts (#911)
470025de is described below
commit 470025dec4d30d9f9b38477cac968a553bbc677f
Author: Minseok Song <[email protected]>
AuthorDate: Mon Aug 17 09:47:05 2026 +0900
fix: avoid recursive hashCode in write holder contexts (#911)
Co-authored-by: ian zhang <[email protected]>
Co-authored-by: DeleiGuo <[email protected]>
---
.../write/metadata/holder/WriteSheetHolder.java | 2 +-
.../write/metadata/holder/WriteTableHolder.java | 2 +-
.../write/metadata/holder/WriteWorkbookHolder.java | 2 +-
.../metadata/holder/WriteHolderHashCodeTest.java | 66 ++++++++++++++++++++++
4 files changed, 69 insertions(+), 3 deletions(-)
diff --git
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteSheetHolder.java
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteSheetHolder.java
index 98923e6c..c8635440 100644
---
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteSheetHolder.java
+++
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteSheetHolder.java
@@ -47,7 +47,7 @@ import org.apache.poi.xssf.usermodel.XSSFSheet;
*/
@Getter
@Setter
-@EqualsAndHashCode
+@EqualsAndHashCode(exclude = {"parentWriteWorkbookHolder",
"hasBeenInitializedTable"})
@NoArgsConstructor
public class WriteSheetHolder extends AbstractWriteHolder {
/**
diff --git
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteTableHolder.java
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteTableHolder.java
index fc1b21a4..f4ab7c01 100644
---
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteTableHolder.java
+++
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteTableHolder.java
@@ -38,7 +38,7 @@ import org.apache.fesod.sheet.write.metadata.WriteTable;
*/
@Getter
@Setter
-@EqualsAndHashCode
+@EqualsAndHashCode(exclude = "parentWriteSheetHolder")
public class WriteTableHolder extends AbstractWriteHolder {
/***
* poi sheet
diff --git
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteWorkbookHolder.java
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteWorkbookHolder.java
index 516d99b6..7750e80a 100644
---
a/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteWorkbookHolder.java
+++
b/fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteWorkbookHolder.java
@@ -70,7 +70,7 @@ import org.apache.poi.xssf.usermodel.XSSFWorkbook;
*/
@Getter
@Setter
-@EqualsAndHashCode
+@EqualsAndHashCode(exclude = "workbookWriteHandlerContext")
@Slf4j
public class WriteWorkbookHolder extends AbstractWriteHolder {
/***
diff --git
a/fesod-sheet/src/test/java/org/apache/fesod/sheet/write/metadata/holder/WriteHolderHashCodeTest.java
b/fesod-sheet/src/test/java/org/apache/fesod/sheet/write/metadata/holder/WriteHolderHashCodeTest.java
new file mode 100644
index 00000000..f545b3d9
--- /dev/null
+++
b/fesod-sheet/src/test/java/org/apache/fesod/sheet/write/metadata/holder/WriteHolderHashCodeTest.java
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fesod.sheet.write.metadata.holder;
+
+import
org.apache.fesod.sheet.write.handler.context.WorkbookWriteHandlerContext;
+import org.apache.fesod.sheet.write.metadata.WriteSheet;
+import org.apache.fesod.sheet.write.metadata.WriteTable;
+import org.apache.fesod.sheet.write.metadata.WriteWorkbook;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class WriteHolderHashCodeTest {
+
+ @Test
+ void workbookHolderHashCodeShouldNotRecurseThroughWorkbookHandlerContext()
{
+ WriteWorkbookHolder workbookHolder = new WriteWorkbookHolder(new
WriteWorkbook());
+ workbookHolder.setWorkbookWriteHandlerContext(new
WorkbookWriteHandlerContext(null, workbookHolder));
+
+ Assertions.assertDoesNotThrow(workbookHolder::hashCode);
+ }
+
+ @Test
+ void
writeHolderHashCodeShouldNotRecurseThroughParentAndInitializedHolderReferences()
{
+ WriteWorkbookHolder workbookHolder = new WriteWorkbookHolder(new
WriteWorkbook());
+ WriteSheetHolder sheetHolder = new WriteSheetHolder(writeSheet(),
workbookHolder);
+ WriteTableHolder tableHolder = new WriteTableHolder(writeTable(),
sheetHolder);
+
+
workbookHolder.getHasBeenInitializedSheetIndexMap().put(sheetHolder.getSheetNo(),
sheetHolder);
+
workbookHolder.getHasBeenInitializedSheetNameMap().put(sheetHolder.getSheetName(),
sheetHolder);
+ sheetHolder.getHasBeenInitializedTable().put(tableHolder.getTableNo(),
tableHolder);
+
+ Assertions.assertDoesNotThrow(workbookHolder::hashCode);
+ Assertions.assertDoesNotThrow(sheetHolder::hashCode);
+ Assertions.assertDoesNotThrow(tableHolder::hashCode);
+ }
+
+ private static WriteSheet writeSheet() {
+ WriteSheet writeSheet = new WriteSheet();
+ writeSheet.setSheetNo(0);
+ writeSheet.setSheetName("Sheet1");
+ return writeSheet;
+ }
+
+ private static WriteTable writeTable() {
+ WriteTable writeTable = new WriteTable();
+ writeTable.setTableNo(0);
+ return writeTable;
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
