SyedIshmumAhnaf commented on issue #1017:
URL: https://github.com/apache/fesod/issues/1017#issuecomment-5308767379
I’d like to work on the java.sql.Timestamp converter support.
My proposed approach is to follow the existing Date / LocalDateTime
converter pattern and add a dedicated Timestamp converter family under
org.apache.fesod.sheet.converters:
* TimestampDateConverter
* Default write path for Timestamp
* Preserve the existing date-format handling used by the other temporal
converters
* TimestampNumberConverter
* Read Excel numeric date values into Timestamp
* Write Timestamp values as Excel date serials
* Reuse the existing date utilities and respect use1904windowing
* TimestampStringConverter
* Read and write string values using the existing DateUtils
formatting/parsing behavior
* Respect @DateTimeFormat and the configured locale
For registration, I plan to follow the current LocalDateTime setup in
DefaultConverterLoader:
* register the Number and String converters in initAllConverter()
* register the Date converter as the default write converter
* register the String converter for string-formatted writes
Since converter lookup is keyed by the declared Java class, the existing
java.util.Date converters do not automatically cover fields declared as
java.sql.Timestamp, so I would keep the change scoped to adding explicit
Timestamp support rather than changing the converter lookup mechanism.
For tests, I plan to add a dedicated TimestampConverterTest covering the
converter keys and read/write behavior, including the relevant date-format /
1904-windowing cases, plus the existing loader or round-trip coverage where
appropriate.
I’ll keep the implementation JDK 8 compatible and limited to the Timestamp
slice of this issue.
If this direction looks good, I’d be happy to take it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
